Code review summary

Table of Contents

Follow style guide for Python Code (PEP 8), if the team does that have any other preferences
Use uniform writing style (of variables, functions, classes, files)
Use understandable naming (for variables, functions, classes, files)
Use English
Do not create separate code for completing tasks
Do not duplicate code
Do not use global variables
Use pyrealsense2
Use manual camera exposure and white balance
Use wide camera resolutions and higher frame rates
Align camera depth frames with color frames when using depth data
Use serial.tools.list_ports (or equivalent) to find correct serial port
Use enums
Avoid unnamed/hardcoded/repeated constants
Create configuration files for constants that need to be changed
Use loops instead of repeating similar code
Keep different parts of the code separate (separation of concerns)
Use state machine for game logic
Create separate functions for state handlers
Make manual control one of the game logic states
Do not use hardcoded movement functions
Use proportional driving
Use omni-motion to calculate motor speeds
Do not open serial port connection multiple times
Do not send commands to mainboard too frequently
Close opened resources (camera, serial port, files)
Fix typos
Remove unused code
Use WebSockets for receiving referee signals
Do not send anything over WebSocket to robot basketball manager
Make sure that all the functionality has been implemented that is required in the task description
Test and review the code
Do not overuse threads
Use unpacking operator (in Python)
Use map() or list comprehension (in Python)
Use elif (else if)
Throw and handle exceptions
Create connect/open method for serial connection
Sample multiple depth pixels to find less noisy distance
Avoid driving too close to basket
Other code style improvements
Performance optimisation
Other

Follow style guide for Python Code (PEP 8), if the team does that have any other preferences

https://peps.python.org/pep-0008/

Use uniform writing style (of variables, functions, classes, files)

Use understandable naming (for variables, functions, classes, files)

Use English

Do not create separate code for completing tasks

Do not duplicate code

Do not use global variables

Use pyrealsense2

Use manual camera exposure and white balance

Use wide camera resolutions and higher frame rates

Align camera depth frames with color frames when using depth data

Use serial.tools.list_ports (or equivalent) to find correct serial port

Use enums

Avoid unnamed/hardcoded/repeated constants

Create configuration files for constants that need to be changed

Use loops instead of repeating similar code

Keep different parts of the code separate (separation of concerns)

Use state machine for game logic

Create separate functions for state handlers

Make manual control one of the game logic states

Do not use hardcoded movement functions

Use proportional driving

Use omni-motion to calculate motor speeds

Do not open serial port connection multiple times

https://github.com/ut-robotics/picr21-team-jordan/issues/24

Do not send commands to mainboard too frequently

https://github.com/ut-robotics/picr21-team-shaq/issues/31

Close opened resources (camera, serial port, files)

https://github.com/ut-robotics/picr21-team-jordan/issues/52

Fix typos

https://github.com/ut-robotics/picr21-team-jordan/issues/40

Remove unused code

Use WebSockets for receiving referee signals

https://github.com/ut-robotics/picr21-team-jordan/issues/65

Do not send anything over WebSocket to robot basketball manager

https://github.com/ut-robotics/picr21-team-kobe/issues/52

Make sure that all the functionality has been implemented that is required in the task description

https://github.com/ut-robotics/picr21-team-jordan/issues/67

Test and review the code

Do not overuse threads

Use unpacking operator (in Python)

https://github.com/ut-robotics/picr21-team-tlo-rock/issues/17

Use map() or list comprehension (in Python)

https://github.com/ut-robotics/picr21-team-tlo-rock/issues/19

Use elif (else if)

https://github.com/ut-robotics/picr21-team-tlo-rock/issues/65 s == Use finally clause
https://github.com/ut-robotics/picr21-team-kobe/issues/81

Throw and handle exceptions

https://github.com/ut-robotics/picr21-team-kobe/issues/10

Create connect/open method for serial connection

https://github.com/ut-robotics/picr21-team-kobe/issues/11

Sample multiple depth pixels to find less noisy distance

https://github.com/ut-robotics/picr21-team-kobe/issues/83

Avoid driving too close to basket

https://github.com/ut-robotics/picr21-team-kobe/issues/93

Other code style improvements

Performance optimisation

https://github.com/ut-robotics/picr21-team-kobe/issues/84

Other